Urllib3 request hook #660
Merged
Urllib3 request hook #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais
reviewed
Sep 3, 2021
.../opentelemetry-instrumentation-urllib3/src/opentelemetry/instrumentation/urllib3/__init__.py
Outdated
Show resolved
Hide resolved
6 tasks
lzchen
reviewed
Sep 7, 2021
CHANGELOG.md
Outdated
| @@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| ## [Unreleased](https://github.com/open-telemetry/opentelemetry-python/compare/v1.5.0-0.24b0...HEAD) | |||
|
|
|||
| ### Changed | |||
|
|
|||
| - `opentelemetry-instrumentation-urllib3` Added `_ExtendedRequestHookT` as an optional type of `request_hook`. | |||
There was a problem hiding this comment.
Is this description still accurate?
There was a problem hiding this comment.
sorry, it wasn't, pushed an update to it just now
ItayGibel-helios
force-pushed
the
urllib3_request_hook
branch
from
62cf7e4 to
7bce6e8
Compare
owais
approved these changes
Sep 13, 2021
srikanthccv
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding an option for an extended form of Urllib3 request hook with additional two arguments:
Type of change
How Has This Been Tested?
Added a unit test named
test_extended_request_hooktesting the extended argumentsDoes This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.